Prior to this fix, stubbing a specific outcome with AbTest#chooses
would occasionally set the 'shown' bit on a participant
because the code at
https://github.com/assaf/vanity/blob/469917acf/lib/vanity/experiment/ab_test.rb#L242
noticed that the persisted participant's alternative differed
from the alternative selected by the hashing algorithm in #alternative_for
This would cause problems downstream in the conversion code
because #ab_showing returns true on this participant.
Prior to this fix, stubbing a specific outcome with AbTest#chooses would occasionally set the 'shown' bit on a participant because the code at https://github.com/assaf/vanity/blob/469917acf/lib/vanity/experiment/ab_test.rb#L242 noticed that the persisted participant's alternative differed from the alternative selected by the hashing algorithm in #alternative_for
This would cause problems downstream in the conversion code because #ab_showing returns true on this participant.