assaf / vanity

Experiment Driven Development for Ruby
http://vanity.labnotes.org
MIT License
1.55k stars 269 forks source link

Set minimum Ruby Version to 2.5; add and apply Rubocop #376

Closed frostmark closed 2 years ago

frostmark commented 2 years ago

Closes https://github.com/assaf/vanity/issues/374

bensheldon commented 2 years ago

@frostmark here's the Rubocop config I use for GoodJob:

https://github.com/bensheldon/good_job/blob/2edcd0268ed2718c799776735e597339c2cf34aa/.rubocop.yml

I also wouldn't object to using StandardRb either, though I prefer inheriting it through Rubocop rather than using it on its own. Something like this: https://gist.github.com/gavvvr/5873313c6a87ba1d32ea31920d0557f4

I'd like to see this checked in CI, and I think we should run the cops/get-to-green as part of this PR so we can review the results of the rules.

frostmark commented 2 years ago

@bensheldon Can you take a look, please?

frostmark commented 2 years ago

@bensheldon ping ping 😄

bensheldon commented 2 years ago

@frostmark thanks for the extra ping! This looks excellent to me. 🙌

I intend to merge this, and then bump the major version to Vanity 4.0.