assaf / zombie

Insanely fast, full-stack, headless browser testing using node.js
http://zombie.js.org/
MIT License
5.65k stars 518 forks source link

browser.fill().fill() not a function #1176

Closed phillytan closed 5 years ago

phillytan commented 6 years ago

Before upgrading to Zombie V6.1.3, the browser.fill().fill() will work. However upon upgrading to Zombie V6.1.3, the test fails and returns as not a function.

Node Version: v10.11.0 macOS Version: Mojave (10.14)

jatinseth2007 commented 6 years ago

I am facing the same error

TheFive commented 6 years ago

i have split my calls from browser.fill().click() to browser.fill() browser.click()

fill now returns a promise (as i have understood the update docu) and not a browser.

MiloATH commented 5 years ago

This is intended behavior (#1054). Consider something along the lines of the following instead:

browser.fill('email', 'zombie@underworld.dead')
  .then(() => browser.fill('password', 'eat-the-living'))
  .then(() => browser.pressButton('Sign Me Up!', done));

This issue can be closed.

assaf commented 5 years ago

👍

avimar commented 4 years ago

Can you please update the quick-start on the "The Bite" please? I google it and found this right away, so it's wasn't too bad. After that change, it seemed to work fine! http://zombie.js.org/

It lists:

    before(function(done) {
      browser
        .fill('email',    'zombie@underworld.dead')
        .fill('password', 'eat-the-living')
        .pressButton('Sign Me Up!', done);
    });
Roxar7 commented 3 years ago

It looks like the documentation in http://zombie.js.org/ is outdated and still lists:

before(function(done) {
      browser
        .fill('email',    'zombie@underworld.dead')
        .fill('password', 'eat-the-living')
        .pressButton('Sign Me Up!', done);
    });

Can somebody help to update it ?