Adding packet limit to merged pcap

assafmo / joincap

Merge multiple pcap files together, gracefully.

MIT License

211 stars 22 forks source link

Adding packet limit to merged pcap #9

Closed AfakTolgi closed 3 months ago

AfakTolgi commented 3 months ago

Limit the Number of packets in the final merged pcap

Overview: This PR resolves an issue where the user can limit the number of packets in the final merged pcap without any other command-line utility

Changes Made:

Added a new flag -c which takes a positive integer as an argument
based on this flag we limit the number of packets that are being written in the final merged pcap

Testing:

Unit tests covering new functionality.

AfakTolgi commented 3 months ago

I updated the review, let me know if it looks good

assafmo commented 3 months ago

Thanks!