The branch "next" contains a nice concept for game accounts.
The following issues were identified related to the creation and authentication of game accounts:
Creation of game account requires playing ~10 minutes against bots. The idea is to improve the security of the private key that way. In my opinion we can not expect new players to play offline before they are allowed to play online. It would be better if we can avoid this prerequisite.
During game account creation and authentication the user is sometimes guided via menus and sometimes via console output. For example, progress notification is shown in console instead of menu. It would be better if the workflow is provided seamlessly within the menu structure instead.
There should be a possibility to remember the password for the game account. Otherwise all people are forced to enter the password at startup. For security reasons the recommended option in the menu should be NOT to remember the password.
Authentication with remembered passwords should be done automatically at startup so that subsequent /connect commands from the console do not fail due to missing authentication.
If the user declines to create a new game account there will be cryptic errors if he/she tries to connect to a server via server list or via console (/connect). The server list should check if the user is authenticated.
Terminology is not always consistent "account" vs. "game account" vs. "client ID".
The console output if sometimes too technical for example fingerprints/hash values and filenames are printed to the console.
There should be an option in the menus to reset the game account because otherwise people will not be able to play online anymore if they forgot their password.
The branch "next" contains a nice concept for game accounts.
The following issues were identified related to the creation and authentication of game accounts: