assaultcube / AC

AssaultCube
859 stars 221 forks source link

Raise max download size from 1 to 2 MB #441

Closed u0043 closed 2 years ago

u0043 commented 2 years ago

Downloads of unzipped files hosted on packages.cubers.net or other package-servers will be dismissed if those exceed the maximum size of 1 MB. This change raises the threshold to 2 MB, allowing larger files to be downloaded successfully.

The 1 MB limit used to be in place ever since, but wasn't preventing larger files from being downloaded in versions prior to v1.3 (bug?). Therefore we now already have files hosted on the package-server, which exceed 1 MB (and are smaller than 2 MB).

In order to maintain the user experience and spare contributors reworking the files in question, this raise of the limit would fix the current issues.

ac-stef commented 2 years ago

The limit is per file. What kind of AC file does not fit in 1 MB?

u0043 commented 2 years ago

Hey stef, Mr.Floppy here, hope you're doing fine.

I actually expected you eventually questioning this change. :) Long story short: I f*cked up with some sound files, not realizing that 1.6 MB-ish is rather large when it comes to AC. My focus was set on the artistic side... v1.2 allowed the download regardless the 1 MB limit, so I just learned there's an issue when v1.3 went live.

Now it's either rework those sound files from scratch (need to be shortened, already low quality/high compression), or raise the limit.

We had a short discussion with flowtron about this on discord. He said 2 MB would be OK, even though any content for AC should kept light-weight - read well below 1 MB - in the future.

ac-stef commented 2 years ago

"and can even run over a 56 Kbps connection"

Even one megabyte will clog said connection for well over two minutes. Your file will probably take four minutes. Someone should change "run" to "walk".

Akimbo2 was set up to deliver three different sets of quality and filesize for all auto-downloadable mapmodels and images. Maybe someone should add a way to auto-shrink sound files as well.

At least iguana can finally use that 1.9 MB turbine mapmodel. Is he still around?