Closed sebastienfr closed 8 years ago
Hello @sebastienfr, thanks for contribution!
I have few comments on this:
.editorconfig
file, it doesn't really belong to this feature.chan *amqp.Blocking
— no need for pointer here, original amqp lib exposed amqp.Blocking, not pointer to it.(*Client).blocking
channel. Some buffering will be nice to have.(*Client).reportBlocking
used only once and without checking return, it will be better to inline its body and remove method.like this:
case blocking := <-chanBlocking:
select {
case c.blocking <- blocking:
default:
}
}
Thanks for your careful review. Here are the changes. I was able to test it by running a rabbitmq in a docker container and allocating only 300m of memory to my docker-machine and it works fine. I'll got the blocking true / low memory.
@sebastienfr awesome! Looks good.
@pavel-d please merge this.
Closes #8 support of blocking notification in amqp. Missing some tests. I was not able to block rabbit server by limiting resources to do the testing.