assembla / cony

Simple AMQP wrapper around github.com/streadway/amqp
BSD 2-Clause "Simplified" License
174 stars 46 forks source link

feat(client): allow support of blocking notification #9

Closed sebastienfr closed 8 years ago

sebastienfr commented 8 years ago

Closes #8 support of blocking notification in amqp. Missing some tests. I was not able to block rabbit server by limiting resources to do the testing.

kron4eg commented 8 years ago

Hello @sebastienfr, thanks for contribution!

I have few comments on this:

like this:

case blocking := <-chanBlocking:
    select {
    case c.blocking <- blocking:
    default:
    }
}
sebastienfr commented 8 years ago

Thanks for your careful review. Here are the changes. I was able to test it by running a rabbitmq in a docker container and allocating only 300m of memory to my docker-machine and it works fine. I'll got the blocking true / low memory.

kron4eg commented 8 years ago

@sebastienfr awesome! Looks good.

@pavel-d please merge this.