search

assemble / assemble-handlebars

Assemble engine plugin for Handlebars templates
https://github.com/assemble/assemble
MIT License
8 stars 19 forks source link

Update to Handlebars 3.0.0 #22

Closed spacedawwwg closed 9 years ago

brunowego commented 9 years ago

+1

JDillon522 commented 9 years ago

@spacedawwwg or someone else: Try triggering the travis ci build again. There is absolutely no reason this should not pass. For redundancy's sake I forked it and tested it locally and its fine. I'd really like the ability to use some of Handlebar's 2.0 features with my assemble projects.

jonschlinkert commented 9 years ago

It looks like it's just node.js 0.8 failing. @doowb I don't have a problem merging this. We can also update travis, there is no reason to continue supporting 0.8

jonschlinkert commented 9 years ago

done! (cross your fingers! :)

brunowego commented 9 years ago

new tag? :package:

brunowego commented 9 years ago

Thanks :+1:

jonschlinkert commented 9 years ago

no prob, please let me know asap if this causes issues. Also @doowb brought up something. we might need to also bump the handlebars version in the 0.5.x version of handlebars-helpers. I just got back from vacation and haven't looked yet. If someone else wants to expedite and look into it that would be great. If it does need to be bumped there, we'll need to make sure all tests are passing too.

JDillon522 commented 9 years ago

FYI I made a PR to update the handlebar-helpers here