search

assemble / assemble-handlebars

Assemble engine plugin for Handlebars templates
https://github.com/assemble/assemble
MIT License
8 stars 19 forks source link

Bump the handlebars helpers #36

Closed LaurentGoderre closed 7 years ago

LaurentGoderre commented 7 years ago

Fixes assemble/grunt-assemble#31

LaurentGoderre commented 7 years ago

@jonschlinkert I am using the 0.6.0 handlebars-helpers combination for which the helpers have been tested against.

jonschlinkert commented 7 years ago

@LaurentGoderre how extensive are the tests? I'm not sure how compatible the 0.6.0 helpers are.

LaurentGoderre commented 7 years ago

@jonschlinkert I just updated the tests. 0.6.0 was not quite compatible but I think I fixed it. Can you review the change to this as well as the tests I wrote? https://github.com/assemble/assemble-handlebars/blob/master/test/core_test.js

LaurentGoderre commented 7 years ago

@jonschlinkert I also ran the tests in grunt-assemble with this and it all passed.

LaurentGoderre commented 7 years ago

@jonschlinkert any objection with me merging this?

doowb commented 7 years ago

@LaurentGoderre I'm testing this out by running it through a few projects. I think the reason that we haven't updated this is because when handlebars-helpers@0.6.0 was published there were a lot of changes to how the helpers were registered and helpers were removed and added. Because of this, we'll need to bump the minor here and in grunt-assemble since these are breaking changes.

Have you tried the latest version of handlebars-helpers yet?

LaurentGoderre commented 7 years ago

I haven't tested the latest but I know that the version here fixes the issues mentioned at the top. That is what I'm trying to solve. I was thinking of bumping it and bumping minor version and do the same to assemble so users can choose which version they want.

doowb commented 7 years ago

We'll definitely have to bump the minors. Most of the helpers are working fine but upgrading a project will require template changes.

I commented in the code on a change that should be made, then I think this is okay to merge. We'll then need to update grunt-assemble and document some of the changes.

LaurentGoderre commented 7 years ago

Any update on this?

doowb commented 7 years ago

Sorry for the delay. I'll get this published and update grunt-assemble too.