search

assemble / grunt-assemble-i18n

Assemble middleware for adding i18n support to projects.
24 stars 8 forks source link

Added the options to specify languages from grunt (#24) #25

Closed LaurentGoderre closed 10 years ago

jonschlinkert commented 10 years ago

this looks good! since we have tests implemented, perhaps we should add some tests before merging though...?

LaurentGoderre commented 10 years ago

Yeah of course! I'm not all that familiar to writing test but I'll take the first crack at it.

This allows us to use a pretty crazy workflow! We have our translation in a Google Spreadsheet, we run a task that generates the json file and then use the output of the task to specify the list of languages

jonschlinkert commented 10 years ago

:+1:

LaurentGoderre commented 10 years ago

Ok, I added the tests

LaurentGoderre commented 10 years ago

Should we turn on travis for this repo?

ain commented 10 years ago

Definitely.

LaurentGoderre commented 10 years ago

Let me know when this can be merged.

jonschlinkert commented 10 years ago

awesome! agreed, looks great!

LaurentGoderre commented 10 years ago

Done!

jonschlinkert commented 10 years ago

it's all your @LaurentGoderre :-) you can merge whenever you want!

LaurentGoderre commented 10 years ago

:D