assemble / grunt-assemble-i18n

Assemble middleware for adding i18n support to projects.
24 stars 8 forks source link

Moved the i18n helper to this plugin #43

Closed LaurentGoderre closed 10 years ago

LaurentGoderre commented 10 years ago

Because of use case like #33, it would be ideal to package all of i18n in one place

LaurentGoderre commented 10 years ago

Comments got lost here is a copy

jonschlinkert commented on 1d3ac8a an hour ago

@LaurentGoderre wouldn't it be better to keep this a separate repo and just require it in? I agree that it should be exposed on this repo, but I think it should still be a separate module - users could use any handlebars helper they want with this plugin. just my 2c

LaurentGoderre commented on 1d3ac8a 41 minutes ago

My understanding is that I'm merely adding an extra helper specifically for i18n. Isn't that what I am doing? I think it would be a lot clearer if everything was self contained within this plugin. Not that I would remove this helper from the core helpers

LaurentGoderre commented 10 years ago

@doowb @jonschlinkert does my rationale make sense?

jonschlinkert commented 10 years ago

yeah, It probably will be easier to maintain this way. The user can still use their own i18n helper if they want.

LaurentGoderre commented 10 years ago

Exactly. ALso, chances arre that if they use i18n, they will want to use it in the front matter, which means they will need this also. It makes it easier for user if there is a plugin to deal with all things i18n.