search

assemble / grunt-assemble-i18n

Assemble middleware for adding i18n support to projects.
24 stars 8 forks source link

Add translation keys to page context #44

Closed LaurentGoderre closed 10 years ago

LaurentGoderre commented 10 years ago

This is a cleanup of #33

LaurentGoderre commented 10 years ago

@ain @jonschlinkert @doowb I think we should merge and fix issues in seperate PRs. What do you think?

I also think we should make test cases more granular and simplistic instead of mixing them all together.

ain commented 10 years ago

I'd prefer merging PRs based on context. There are cases where PR is improved as it sometimes lands faulty and so you get multiple commits per PR and I consider it completely normal as long as everything is readable and shares the scope. Generally, as PRs land, they should definitely have a scope of either a feature or a fix, not mixed compound PRs, if that's what you meant.

jonschlinkert commented 10 years ago

@LaurentGoderre I think pragmatically it depends on the repo. I'll follow whatever conventions you decide to go with on this repo. However you want to run this is great with me

ain commented 10 years ago

:+1:

LaurentGoderre commented 10 years ago

This one is clearly a feature. and only one. Anywways @ain, are we ready to merge this?

ain commented 10 years ago

@LaurentGoderre as you know it's in use in production on a site with more than 5k pages in nearly 50 languages by now, for quite some time ;) I think it is ready to be merged, yes :)

LaurentGoderre commented 10 years ago

Btw, did you see my PR to move the helper to this project?

jonschlinkert commented 10 years ago

:+1: