assembleco / slim

A (slim) System for Laboratory Information Management
https://stoic-pare-ea69d2.netlify.com/
0 stars 1 forks source link

Handle server errors gently #61

Open c-lliope opened 6 years ago

c-lliope commented 6 years ago

In src/Assemble.js, both the run() and watch() functions make no distinction between successful results from the server and errors.

This means that error messages often get passed to csvParse(), which throws an exception when it sees uncooperative data. The whole site grinds to a halt, showing the create-react-app error page.

I'm not sure what the ideal solution looks like, but at the very least we should display a note to the user saying that something's gone wrong.

As much as possible, we should avoid interrupting the user's flow.