search

assemblee-virtuelle / semapps

A toolbox to create semantic web applications
https://semapps.org
Apache License 2.0
88 stars 9 forks source link

Expose uploadFile method in dataProvider.js #1330

Closed SlyRock closed 2 weeks ago

SlyRock commented 2 weeks ago

As seen with @srosset81 I exposed the uploadFile method on the semantic-data-provider package

Laurin-W commented 2 weeks ago

Hey @SlyRock, cool! That's really useful :D Congrats!

One more comment from my side: Unfortunately, we don't use typescript everywhere right now but we have a types file: https://github.com/assemblee-virtuelle/semapps/blob/88b68ce38c76c3b9e2998a12e84483a92140858a/src/frontend/packages/semantic-data-provider/src/dataProvider/types.ts#L95-L99

Could you add the method signature here as well? :)

refreshConfig: () => Promise<Configuration>; // This is missing as well but that's not your fault, haha
uploadFile: (rawFile: File, config: Configuration) => Promise<string | null>;
SlyRock commented 2 weeks ago

Hey @SlyRock, cool! That's really useful :D Congrats!

One more comment from my side: Unfortunately, we don't use typescript everywhere right now but we have a types file:

https://github.com/assemblee-virtuelle/semapps/blob/88b68ce38c76c3b9e2998a12e84483a92140858a/src/frontend/packages/semantic-data-provider/src/dataProvider/types.ts#L95-L99

Could you add the method signature here as well? :)

refreshConfig: () => Promise<Configuration>; // This is missing as well but that's not your fault, haha
uploadFile: (rawFile: File, config: Configuration) => Promise<string | null>;

Hey Laurin, Thanks for being thankful ^^

I'm adding the signatures right now :)

PS : very happy to join you guys on this and even more so that my first PR is deemed useful ^^