Fix for issue #109 - After uploading a video the thumbnail is missing

assembler / attachinary

Attachments handler for Rails that uses Cloudinary for storage.

MIT License

294 stars 129 forks source link

Fix for issue #109 - After uploading a video the thumbnail is missing #121

Open bluengreen opened 8 years ago

bluengreen commented 8 years ago

Added resource_type to $cloudinary.url call to get correct url for video thumbnails

orlando commented 8 years ago

Hey @bluengreen can we add a small test for this please?

Also, what about squashing these commits?

Thanks!

bluengreen commented 8 years ago

Is there an existing test for that code?

orlando commented 8 years ago

I don't think we have a test for the thumbnail generation. I'll say that is fine add this to https://github.com/assembler/attachinary/blob/master/spec/features/notes_spec.rb.

Also if you can add a bit of context to this PR, I know that cloudinary defaults to resource_type: image, but why we are doing this instead of using resource_type: auto for example.