assemblerflow / docker-imgs

A repository to store all the docker images used in flowcraft
GNU General Public License v3.0
4 stars 4 forks source link

Can't pull images from dockerhub, missing manifests #7

Open t0rrant opened 5 years ago

t0rrant commented 5 years ago

From at least last Thursday I could no longer pull flowcraft images from the docker registry. The error states that there are missing manifests. Other images from the community or official images work fine in any of my setups.

Example

# for f in "${flowcraft[@]}"; do docker pull $f; done
Using default tag: latest
Error response from daemon: manifest for flowcraft/fastqc:latest not found
Using default tag: latest
Error response from daemon: manifest for flowcraft/trimmomatic:latest not found
Using default tag: latest
Error response from daemon: manifest for flowcraft/true_coverage:latest not found
Using default tag: latest
Error response from daemon: manifest for flowcraft/spades:latest not found
Using default tag: latest
Error response from daemon: manifest for flowcraft/bowtie2_samtools:latest not found
Using default tag: latest
Error response from daemon: manifest for flowcraft/pilon:latest not found

Versions

Shifter: 18.03.0 Docker: 18.09.2, build 6247962

cimendes commented 5 years ago

Hello!

Sorry for the very late reply! I see that you're trying to pull the images using "latest" as tag (this is default docker behavior). In our docker hub repos we never use the latest tag, favoring instead to have the tool version and build as tag. For example, for SPAdes it should be docker pull flowcraft/spades:3.12.0-1

Can you confirm that when you correct the tag version you're able to successfully pull the image?

t0rrant commented 5 years ago

Hi @cimendes,

yes, when specifying a version it works. The idea behind not using the latest is due to different types of tests for each different version right?

cimendes commented 5 years ago

Hello. It's a way to easily identify which software version corresponds to each container. For flowcraft we use these tags to keep track of the tool version implemented in each component. A "latest" tag can could be added, with the most recent version of a container, but for the sake of reproducibility and validation, we avoid it.