assemblerflow / flowcraft

FlowCraft: a component-based pipeline composer for omics analysis using Nextflow. :whale::package:
GNU General Public License v3.0
241 stars 44 forks source link

Merging inspect and report #181

Open jacarrico opened 5 years ago

jacarrico commented 5 years ago

Using flowcraft repeateadly I arrived to the conclusion that if the report can be only a flag on the inspect mode it would be better and would avoid to have 2 open terminal to get the same result. What are your opinions?

ODiogoSilva commented 5 years ago

That could work, but the two services should be kept separate. We could either create a new flowcraft mode (flowcraft one-seeing-eye) that would actually run the two services in parallel and return both links? Or add a flag to each report and inspect to track each one, but that seams less intuitive.

jacarrico commented 5 years ago

@ODiogoSilva I agree to keep it separate because the user might want the option not to send results data for a webservice. It returns the inspect link with the button and the popup saying reports are available

and I would keep inspect. Report is a special case of inspecting the results

cimendes commented 5 years ago

Usually when you already a have a complete analysis you don't return to the insect of the pipeline. It's arguably much more useful to have both services running while a pipeline is still executing. An alternative to the new flowcraft mode is to add a flag to the inspect mode to also launch the report service, in watch mode. Something like flowcraft inspect -m broadcast --report). I'm not against the suggested new mode by any means.