Closed PhilPalmer closed 5 years ago
@PhilPalmer
1 - For non-boolean parameters, the falsy value should be null
like you provided. false
is mostly reserved for boolean parameters.
2 - There may be, but with additional time. For now we can go with a working solution and later optimize.
3 - Placement is fine.
Hey,
I've added
bwa
,mark_duplicates
,base_recalibrator
&haplotype_caller
components.Anyone please review, especially @ODiogoSilva
Things I'm not sure on & you might want to check:
default
tofalse
rather thannull
?${fasta}.fasta
in the templates forbase_recalibrator
&haplotypecaller
?mark_duplicates
&base_recalibrator
to themapping
class. Would it be better if I made a new one egread_data_manipulation
?