search

assemblerflow / flowcraft

FlowCraft: a component-based pipeline composer for omics analysis using Nextflow. :whale::package:
GNU General Public License v3.0
241 stars 44 forks source link

Moved template file to proper location #221

Closed t0rrant closed 5 years ago

t0rrant commented 5 years ago

refactored print macros to print function changed function names to adhere to PEP8 changed space formatting to adhere to PEP8

Closes: #219 Signed-off-by: Manuel Torrinha manuel.torrinha@tecnico.ulisboa.pt

codecov-io commented 5 years ago

Codecov Report

Merging #221 into master will decrease coverage by 0.58%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #221      +/-   ##
==========================================
- Coverage   41.95%   41.37%   -0.59%     
==========================================
  Files          72       73       +1     
  Lines        6461     6552      +91     
==========================================
  Hits         2711     2711              
- Misses       3750     3841      +91
Impacted Files Coverage Δ
flowcraft/templates/renamePE_samtoolsFASTQ.py 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d3a670a...a357794. Read the comment docs.

cimendes commented 5 years ago

Hi! Thank you for contribution to flowcraft! Unfortunatly moving that rogue file is not that simple :P I'm going to close this PR unmerged but I've started implementing the fix for #219 in a branch. There's at least two components that use this scipt: retrieve_mapped and remove_host. I've updated the template to follow our guidelines and upgraded it to python3, but I haven't tested it. I'll create a PR when I do so.

Best!

Inês

t0rrant commented 5 years ago

Thank you @cimendes, and sorry for any confusion ^_^

Cheers!