Should Diffs be `diff` style?

assert-rs / predicates-rs

Boolean-valued predicate functions in Rust

docs.rs/predicates

Apache License 2.0

173 stars 29 forks source link

Should Diffs be `diff` style? #105

Closed epage closed 3 years ago

epage commented 3 years ago

https://github.com/assert-rs/assert_cmd/issues/121 is an example of long output. We end up showing both sides of the Diff, so it seems redundant to show the unchanged lines as well. Maybe we should only show changed lines.

ajeetdsouza commented 3 years ago

As long as we're only printing one diff rather than both sides separately, I think the redundancy is mitigated. Removing unchanged lines may or may not work for all use cases, perhaps that should be configurable.