assert-rs / predicates-rs

Boolean-valued predicate functions in Rust
docs.rs/predicates
Apache License 2.0
173 stars 29 forks source link

feat: Allow predicates to own object and evaluate against borrowed types #134

Closed rshearman closed 1 year ago

rshearman commented 1 year ago

It is very useful to be able to dynamically construct an object and have that object owned by the predicate, yet evaluate against an unowned type related to the owned one. An obvious example is a String being owned by the predicate but being compared against &strs.

Therefore, implement Predicate for Eq/OrdPredicate that store an object that implements Borrow for the predicate type, replacing existing impls of Predicate for Eq/OrdPredicate and Eq/OrdPredicate<&T>. This is backwards compatible as there are blanket implementations of Borrow for T and Borrow for &T.

Note that Borrow imposes more requirements than are actually required and AsRef would be sufficient. However, AsRef doesn't have a blanket implementation for T and thus the existing impl of Predicate for EqPredicate is still required, but results in a conflict since T may also implement AsRef. Requiring Borrow instead of AsRef is sufficient for common use cases though.

This addresses #20 more completely.