search

assert-rs / predicates-rs

Boolean-valued predicate functions in Rust
docs.rs/predicates
Apache License 2.0
168 stars 29 forks source link

feat!: Disable default regex features #143

Closed jirutka closed 1 year ago

jirutka commented 1 year ago

To avoid infecting the dependency graph with potentially unwanted regex features. If the user wants extra regex features, they should enable them in their project (e.g. just add dependency on "regex" with default features enabled).

epage commented 1 year ago

A major change like this should be discussed in an issue first. I find issue work better for exploring the problem and solution space while PRs are better for discussing the implementation.