Open jirutka opened 1 year ago
This would be a welcome change, as regex
features are a nice low-hanging fruit when reducing bloat.
I wonder about perf-*
features vs unicode-*
features though: while a missing unicode feature will probably show up during testing and the devs will realize that they need to opt in, a missing perf feature might just silently make the binary or the unittests slower. Since they don't cause as much binary bloat (just longer compile times), maybe it makes sense to leave those in for predicate-rs
.
This is a tough one because
regex
to get the features they want but I also don't want to re-exportingI think I'd be more inclined to make the regex
feature off by default instead. That could also possibly be done in mockall
, I'm not aware of its design to say whether it needs it or not (which is how starship is pulling in predicates, I presume)
To avoid infecting the dependency graph with potentially unwanted regex features. If the user wants extra regex features, they should enable them in their project (e.g. just add a dependency on "regex" with default features enabled).
PR #143