Build broken with float-cmp 0.4.1

assert-rs / predicates-rs

Boolean-valued predicate functions in Rust

docs.rs/predicates

Apache License 2.0

173 stars 29 forks source link

Build broken with float-cmp 0.4.1 #78

Closed brson closed 4 years ago

brson commented 5 years ago

After updating my lockfile such that float-cmp went from 0.4.0 to 0.4.1 I see:

error[E0061]: this function takes 2 parameters but 3 parameters were supplied
  --> /home/brian/.cargo/registry/src/github.com-1ecc6299db9ec823/predicates-1.0.1/src/float/close.rs:86:18
   |
86 |         variable.approx_eq(&self.target, self.epsilon, self.ulps)
   |                  ^^^^^^^^^ expected 2 parameters

0x-r4bbit commented 5 years ago

Just ran into the same thing. There was a breaking change introduced in float-cmp a long long time ago but has only been released yesterday: https://github.com/mikedilger/float-cmp/issues/17

mikedilger commented 5 years ago

I'm terribly sorry for breaking float-cmp. I've yanked 0.4.1

epage commented 5 years ago

Understandable. Stuff like that happens.