search

assert-value / assert_value_ruby

MIT License
6 stars 3 forks source link

Fix deprecation warning #2

Closed weshatheleopard closed 8 years ago

gleb commented 8 years ago

Ruby 2.3?

weshatheleopard commented 8 years ago

Yep

gleb commented 8 years ago

Seems like a good change. I wanted to reproduce the warning, but somehow I don't see it with 2.3.0. How do you trigger this warning?

weshatheleopard commented 8 years ago

Add to ~/Rakefile:

Rake::TestTask.new(:test) do |t|
[...]
  t.warning = true
end
gleb commented 8 years ago

I've enabled warnings for assert_value builds too. Any idea how t.warning = true got into your Rakefile? Is this a new standard thing that Rails does, or your/company thing?

weshatheleopard commented 8 years ago

Don't remember how I came to know that flag, but it happened in the past 3 days :)

http://rake.rubyforge.org/classes/Rake/TestTask.html : [RW] warning Request that the tests be run with the warning flag set. E.g. warning=true implies ruby -w used to run the tests.

gleb commented 8 years ago

Released in 1.5.3, thanks.