Remove deprecation warnings from generated assertions

assertj / assertj-assertions-generator

Custom assertions generator

https://joel-costigliola.github.io/assertj/assertj-assertions-generator.html

Apache License 2.0

62 stars 42 forks source link

Remove deprecation warnings from generated assertions #143

Open ebramirez opened 4 years ago

ebramirez commented 4 years ago

The assertions generated uses org.assertj.core.util.Objects.areEqual and org.assertj.core.util.Objects.areEqualArrays which are deprecated and show in the applications warning logs.

Should use the suggested methods instead.

joel-costigliola commented 4 years ago

Fair point, keen to contribute it @ebramirez?

ebramirez commented 4 years ago

Sure!

Here you have it: #144

@joel-costigliola By the way, to run the tests I had to add the javax.annotation-api test dependency. I have not pushed that change as part of the PR just in case this was intentional. Is this a known thing?

joel-costigliola commented 4 years ago

This project was developed with the JDK 8 which provides it but I guess you are using JDK 11 (or even 14!)

ebramirez commented 4 years ago

You absolutely right, I completely forgot about that change.

rob-valor commented 3 years ago

Just wondering, is there a specific reason why this change can't be release yet?