allow the jakarta version of @Generated instead of the javax one.

assertj / assertj-assertions-generator

Custom assertions generator

http://joel-costigliola.github.io/assertj/assertj-assertions-generator.html

Apache License 2.0

61 stars 42 forks source link

allow the jakarta version of @Generated instead of the javax one. #194

Open Zegveld opened 2 years ago

Zegveld commented 2 years ago

all javax modules are being replaced with jakarta, this includes @javax.annotation.Generated. This is replaced by @jakarta.annotation.Generated, allow users to choose which annotation they want on the generated classes.

(I'm also creating a PR for this.)

famaridon commented 2 years ago

rob-valor commented 10 months ago

@joel-costigliola , any reason why the jakarta support doesn't get merged?

joel-costigliola commented 10 months ago

just lack of time, the generator is currently in a limbo state because of that ...

scordio commented 2 months ago

Team decision: We will start the development of the next major version with Java 17 as a baseline to better aid records and jakarta support.

reitzig commented 2 months ago

FWIW, in JDK 21, javax.annotation.Generated is gone so the generated assertions do not compile.

Manually replacing with @javax.annotation.processing.Generated works, of course, but that's not really what we're going for, is it? 😅 We could override all templates, I guess ...

reitzig commented 1 week ago

@scordio Any way we can help? We keep writing assertion classes and would much rather spend the time here. 😅

scordio commented 5 days ago

Hi @reitzig, I appreciate the offer! 🙂 nothing special where you could help, I'm afraid: I'm upgrading dependencies and aligning the parent POM to the latest version, which already brings a few challenges due to the custom JUnit 4 rules... once this is over, it should be possible to speed up the other topics.

I'll keep you posted.