search

assertj / assertj-swing

Fluent assertions for Swing apps
Other
108 stars 52 forks source link

JIDE support #149

Closed gschrader closed 9 years ago

gschrader commented 10 years ago

I found the old jide fest source code here (I'm not sure if that's the original or not) that I was able to convert to assertj-swing. I'm just wondering if you would like to have it as part of this repository (I would do a pull request). There maybe isn't that many people that even require it any more so maybe it's not worth it for you. If not, I'll push it somewhere else in case anyone else needs it.

croesch commented 10 years ago

Hey, yes it would be nice to see a pull request for that! I'm looking forward to merge it into the master branch..

Thanks in advance!

gschrader commented 9 years ago

The one other issue I see that you might have with this is there is no public maven repository for the JIDE dependencies. So compiling the code might be an issue for you. I notice in the old repository the pom has the jide dependencies specified as <scope>provided</scope> so I'm not sure how they handled it back in the day.

gschrader commented 9 years ago

pull request is here

croesch commented 9 years ago

Thanks! They provide a developer API so I'll try retrieving one of these and merge the request as soon as I got that thing running ;-)

croesch commented 9 years ago

@gschrader under which licence is the code available you submitted? Is Peter Murray the owner of code?

gschrader commented 9 years ago

It looks to be an apache license, Yes Peter Murray is the owner, I looked a bit to see if I could find any contact information for him and came up empty.

gschrader commented 9 years ago

Of course now I see that he's starred this repository already :blush: So I guess you can ask @peter-murray if that license still applies or if he has any issues with this merge.

peter-murray commented 9 years ago

I personally, have no issues with the merge, as long as you can satisfy jide's own licences and or requirements.

joel-costigliola commented 9 years ago

thanks @peter-murray. @croesch let's check jide's licences and or requirements to be sure we are doing the right thing.

croesch commented 9 years ago

@peter-murray thanks! And thanks for the quick reply :+1: @joel-costigliola yes. I'm currently waiting for access to their development center and then I'll check what they allow.

But I would say that as long as we don't distribute any of their code (source or compiled) they have no ability to disallow our integration of jide. But I'll check that - to be sure..

croesch commented 9 years ago

Okay, I didn't hear from them since then..

I wrote a mail today, got a quick reply, got the code compiling locally. I'm going to get the licence requirements satisfied now, which might just be a link to their website. But I'm mailing with them to be sure..

croesch commented 9 years ago

support@jidesoft:

If you just compile against it, no need to acknowledge using JIDE.

-> PR merged.

croesch commented 9 years ago

Relesead 1.1.0 of assertj-swing containing jide support.