Add tests and refactor - Githubissues

asset-pipe / asset-pipe-js-writer

Module for reading a CommonJS module entry point and resolves all dependencies into a asset feed.

2 stars 0 forks source link

Add tests and refactor #80

Closed digitalsadhu closed 6 years ago

digitalsadhu commented 6 years ago

JIRA Issue

Status

IN DEVELOPMENT

Description

Adds tests.
Adds assertions around module input.
Refactors module into browserify plugins.
Removes minification.
Removes auto deduping by browserify.
Refactors into small modules.

BREAKING CHANGE: minify option no longer available BREAKING CHANGE: feeds no longer deduped by default

Why??:

Changes to @asset-pipe/js-reader require that feeds no longer do any deduping as this now happens in the reader and doing so before hand causes all kinds of mischief.
Codebase and repository cleanup.
Increase test coverage.

Todos

[x] Tests - additional more advanced integration tests still to add
[x] Documentation - document api changes

Deploy Notes

[ ] Publish
[ ] update @asset-pipe/client with new version of this module
[ ] update (and expand?) integration tests
[ ] update@finn-no/podlet module
[ ] update all podlets using@finn-no/podlet module and re-deploy

Related PRs

None