search

assetgraph / assetgraph-builder

AssetGraph-based build system for web apps and web pages.
BSD 3-Clause "New" or "Revised" License
489 stars 42 forks source link

Missing copyright header in minified javascript #49

Closed mtandersson closed 11 years ago

mtandersson commented 11 years ago

Thanks for a great tool!

When i run 

./node_modules/assetgraph-builder/bin/buildProduction --outroot dir \
  --root anotherdir --version `git log --pretty=format:'%h' -n 1` -less true

Everything works as expected except for that I don't the copyright headers is stript from the minified js file. Is this by design (are there a way to get the copyright headers?) If not I would regard this as an bug.

papandreou commented 11 years ago

Thanks for a great tool!

You're dearly welcome :)

Everything works as expected except for that I don't the copyright headers is stript from the minified js file. Is this by design (are there a way to get the copyright headers?) If not I would regard this as an bug.

Nice find, fixed in assetgraph-builder 1.4.4. The copyright notices were removed by the compressJavaScript transform. Note that only /! ... / comments at the start of a file are considered copyright notices.