assetto-corsa-web / accweb

Assetto Corsa Competizione Server Management Tool via Web Interface.
MIT License
142 stars 54 forks source link

GT4 available? #81

Closed geppo1988 closed 3 years ago

geppo1988 commented 4 years ago

Hi! When are GT4 coming into ACCWEB? :)

Let me know if you need help

Thanks

Kugelschieber commented 4 years ago

I don't know yet, but this should be easy as it only requires adding the new tracks/cars to the options. You can try that if you like.

geppo1988 commented 4 years ago

DO you know which config files are affected? I think they introduced some category ... I haveto see on their documentation

Kugelschieber commented 4 years ago

Okay that's a different case then. I haven't looked at the changes.

mikeev261 commented 4 years ago

It seems like a minor change. They added a new field in settings.json:

"carGroup": "FreeForAll",

FreeForAll is the default, which is essentially just open mixed-class racing.

From the V8 doc:

Defines the car group for this server. Possible values are "FreeForAll", "GT3", "GT4", "Cup", "ST" where “FreeForAll” will allow any driver to join with any car (that he defined as Primary Car). GT3, GT4, Cup, ST will restrict this server to GT3, GT4, Porsche Cup oder Lamborghini Supertrofeo.

geppo1988 commented 4 years ago

So we need just to add this as an option in the ACCWEB when a new lobby is configured....is it a bbig change? I'm a developer but I'm not familiar with your project structure....

Maybe you can tell me which are the files and I'll change them :)

Kugelschieber commented 4 years ago

You can add that field to the server structure here: https://github.com/assetto-corsa-web/accweb/blob/master/server/server.go And to the configuration in the frontend in the components over here: https://github.com/assetto-corsa-web/accweb/tree/master/public/src/components/server_config

geppo1988 commented 4 years ago

Thanks :) How can I compile it once I changed the configs?

Kugelschieber commented 4 years ago

Oh I should have probably added that to the readme. Well you need to have npm (NodeJs) and Go (golang.org) installed. You can then cd into the public directory, run npm i to install all dependencies and npm run build to build the frontend. Afterwards you can start accweb in dev mode by running go run main.go in the root directory.

geppo1988 commented 4 years ago

Hi,

Thanks for the help so far.

changed settings,vue and server.go adding the enxtra field in the json and in the UI but I'm still struggling to get it working. Is there any other step I have to do to get it running locally?

Kugelschieber commented 4 years ago

Hm what error message do you see?

geppo1988 commented 4 years ago

Ok, thanks I managed :)

Once the json are saved properly everything should then works....wight? I'll test it tomorro...and commit when it works :)

Kugelschieber commented 4 years ago

Theoretically yes, you should also check they are loaded in the frontend again.

geppo1988 commented 4 years ago

Yes everything works :) I'll do a final test on my server to see if the lobbies are created correctly :)

I have other features in mind...let's see

mikeev261 commented 4 years ago

Looking forward to it. Thanks for making the change, @geppo1988 !

geppo1988 commented 4 years ago

Somehow I managed to build but when I start the server the lobbes gets close with this error:

"==ERR: Server is outdated and can't connect to the lobby anymore. Please update this server and can't connect to the lobby anymore. Please update this server "

geppo1988 commented 4 years ago

Maybe is better if I wait cause locally the generated json is ok but on the newely built release the property does not get filled in settings.json....

Kugelschieber commented 4 years ago

Sounds like you haven't updated the game.

Kugelschieber commented 4 years ago

Can you create a pull request so I can take a look at the changes?

geppo1988 commented 4 years ago

ok course, I'll do itsoon

geppo1988 commented 4 years ago

I created the pull request :) let me know if you think the changes are fine....probably I struggle just in the building process.....

geppo1988 commented 4 years ago

Let me know if it bbuilds and works on your side so that we can release the 1.9.3 :) with suport of GT4

KingWilly1 commented 4 years ago

I have download the new version 1.10.0 still the same problem.

22338: ==ERR: Server is outdated and can't connect to the lobby anymore. Please update this server

Kugelschieber commented 4 years ago

Did the config version change?

Kugelschieber commented 4 years ago

This sounds more like an issue with the server version itself, not accweb.

KingWilly1 commented 4 years ago

Did you change the exe file ?

Kugelschieber commented 4 years ago

What do you mean? You need to provide the accServer exe yourself, I cannot do that. Please check it's up to date.

KingWilly1 commented 4 years ago

accweb release 1.10.0 is working.

I have updated the exe file, after that the server is up and running.

Thanks for the support guys.

Kugelschieber commented 4 years ago

@geppo1988 close this if it works for you.

geppo1988 commented 4 years ago

ahhhhh maybe that was the issue on m side as well :) I fortgot to updte the accserver....

AKM-Andy commented 4 years ago

Hi Guys this is in changelog....

wakcs commented 4 years ago

Small note, this fix in fact broke GT3 only servers 😅 https://github.com/assetto-corsa-web/accweb/commit/21cfc76ff79745d2409c3d3ac1f8d5dff64e78ef

mikeev261 commented 4 years ago

Can confirm. GT3-only is in-fact broken.

Interestingly, GT4-only works fine. Same with FreeForAll of course. Haven't tested CUP and ST yet.

geppo1988 commented 4 years ago

I fixed already the code for GT3 :) sorry but it was a typo in the code. New release will come soon.

What about isLockedPrepPhase? is there or is just missing in the UI? I'll check if I can add this as well

geppo1988 commented 4 years ago

@AKM-Andy https://www.assettocorsa.net/forum/index.php?threads/the-server-admin-handbook-thread.58245/ if you read in kunos documentation this parameter is not there :/ where have you find it?

luismercury commented 4 years ago

Hi. There is a error image

Is correct "cargroup" GT3_2018 ??

it should be just GT3

Kugelschieber commented 4 years ago

Should be solved in 1.10.1.

AKM-Andy commented 4 years ago

@AKM-Andy https://www.assettocorsa.net/forum/index.php?threads/the-server-admin-handbook-thread.58245/ if you read in kunos documentation this parameter is not there :/ where have you find it?

I found it in Changelog within ACC

AKM-Andy commented 4 years ago

Hi Guys is everyone getting correct version number at bottom of server list as its still showing v1.10.0 on mine & I'm sure its updated???

Kugelschieber commented 4 years ago

Ah yes, I forgot to update that.

AKM-Andy commented 4 years ago

Has "isLockedPrepPhase" been added?

Kugelschieber commented 4 years ago

No, @geppo1988 just fixed the car groups.

AKM-Andy commented 4 years ago

Hi Guys, I have had to add it manually as its needed to stop GT3 cars being behind GT4 on grid because they didn't qualify or joined session late. GT3 cars ploughing through the field at start causes mayhem