search

assetto-corsa-web / acweb

Assetto Corsa Server Management Tool via Web Interface.
MIT License
60 stars 9 forks source link

Couple of fixes to issues I reported :) #14

Closed macedot closed 7 years ago

macedot commented 7 years ago
  1. Change acServer running dir to its own path so checksum calculation for car and tracks should work;
  2. Add parameters for:
    • UDP parameters (needed for stracker/minorating)
    • legal tyres, so one can restrict tyres usage
    • wind parameters for weather
    • fixed setup at entry list (stringl; will point to an existing .ini file at acServer/setups)

Not tested, but should build at least :)

Kugelschieber commented 7 years ago

You modified the database schema, can you please update the db/schema.sql and add a migration script to upgrade from version 1.0.3? Just add a file db/mig_1.0.3_1.0.4.sql containing all instructions that need to be executed. The schema.sql should contain the complete database schema without data and comments.

Also, when I merge this it will break the master branch, since you haven't added your changes to the frontend. Are you familiar with VueJs/JavaScript? In that case can you add the new configurations to the public/app/pages/configuration.js? If not, I can take care of that.

Steps to build, run and (manually) test:

  1. install Go 1.8
  2. install node and npm
  3. install node-sass (npm install -g node-sass)
  4. install MySQL
  5. download minvue and place it into public (https://github.com/DeKugelschieber/vuejs-minify), or just use the linux version (which is present already)
  6. run minvue, node-sass and the server like in the bash scripts (/run, /public/build_app, /public/build_sass)
macedot commented 7 years ago

Done. Should I create a new pull request?

Kugelschieber commented 7 years ago

No your commits get added to this pull request. I'll test the changes :)

Kugelschieber commented 7 years ago

To do local testing, you can also use docker instead of setting up my complete dev environment. Install docker on your machine, setup a mysql database (https://hub.docker.com/_/mysql/) and build the image from within th acweb directory: docker build -t acweb . and then run it like on your server.

It really would help to make sure your changes actually compile and work propperly. I'm thinking about adding unit tests in a future version.

But so far, your code looks really good.

macedot commented 7 years ago

Did it in a hurry before leave to work. Will fix asap :)

macedot commented 7 years ago

Should be enough :) My current internet isn't great so it will take some time to download docker image and test it.

macedot commented 7 years ago

New commits for #10, #12 and #13 .

Kugelschieber commented 7 years ago

Add the new table columns to the migration script please.