Closed dmuhamedagic closed 7 years ago
I'm happy to include this patch. Did you observe something failing because of it?
I don't find a contributor agreement for you yet. Could you kindly provide it? I'll send you the link.
This particular patch is so simple, that I don't think there's any intellectual property issue regarding it, but I'd love to be able to take more from you.
On Sun, Sep 24, 2017 at 10:34:08PM +0000, Alan Robertson wrote:
I'm happy to include this patch. Did you observe something failing because of it?
Yes, the tests regarding the name resolution behaved differently on Debian stretch compared to jessie:
tests/cclass_wrappers_test.py::TestpyNetAddr::test_ipv6_strinit ** (process:111): DEBUG: netaddr_dns_new.1045: Could not resolve 0 - reason: Servname not supported for ai_socktype
** (process:111): DEBUG: netaddr_dns_new.1045: Could not resolve - reason: Servname not supported for ai_socktype
** (process:111): DEBUG: netaddr_dns_new.1045: Could not resolve [0 - reason: Servname not supported for ai_socktype
** (process:111): DEBUG: netaddr_dns_new.1045: Could not resolve [0 - reason: Servname not supported for ai_socktype
** (process:111): DEBUG: netaddr_dns_new.1045: Could not resolve 0 - reason: Servname not supported for ai_socktype
** (process:111): DEBUG: netaddr_dns_new.1045: Could not resolve [0 - reason: Servname not supported for ai_socktype
** (process:111): DEBUG: netaddr_dns_new.1045: Could not resolve ffff - reason: Servname not supported for ai_socktype
** (process:111): DEBUG: netaddr_dns_new.1045: Could not resolve ffff - reason: Servname not supported for ai_socktype
** (process:111): DEBUG: netaddr_dns_new.1045: Could not resolve [ffff - reason: Servname not supported for ai_socktype
** (process:111): DEBUG: netaddr_dns_new.1045: Could not resolve [ffff - reason: Servname not supported for ai_socktype
PASSED
tests/cclass_wrappers_test.py::TestpyNetAddr::test_dns_strinit ** (process:111): DEBUG: netaddr_dns_new.1045: Could not resolve www.linux-ha.org - reason: Servname not supported for ai_socktype
** (process:111): DEBUG: netaddr_dns_new.1045: Could not resolve www.linux-ha.org - reason: Servname not supported for ai_socktype
FAILEDSegmentation fault
There was also a segfault, which needs to be examined separately.
Let getaddrinfo find any net address. gettaddrinfo(3) says: