search

assimilation / assimilation-official

This is the official main repository for the Assimilation project
51 stars 9 forks source link

ctypesgen blocking progress #65

Closed borgified closed 5 years ago

borgified commented 5 years ago

I've_ forked ctypesgen to here https://github.com/assimilation/ctypesgen, since upstream seems to be abandoned. I tried adding the patches as prescribed by davidjamesca/ctypesgen#61 and davidjamesca/ctypesgen#62 and I'm still hitting the same errors indicated by the issues. @Alan-R can you give it a shot at fixing ctypesgen? (make changes directly to assimilation/ctypesgen)

I've also tried other forks like olsonse/ctypesgen but they don't help either.

travis output showing ctypesgen problem: https://www.travis-ci.org/assimilation/assimilation-official/jobs/490881626#L1640

borgified commented 5 years ago

ha.. i just discovered you already forked that repo not too long ago! (https://github.com/Alan-R/ctypesgen) ill wait for those fixes so i can continue after. I'll delete the fork i made.

Alan-R commented 5 years ago

I has already forked it here: https://github.com/Alan-R/ctypesgen to bring it into compliance with Python3. This is worth some attention since python2 is end of life at the end of this year. Not sure if I've pushed my changes back to github yet or not. I'll do that.

I've let PyCharm make a bunch of stylistic changes to bring into better Python style. I'd really just gotten started - but I wanted PyCharm to stop complaining about things. I like tools that keep me from making mistakes, but you have to get the noise level dow.

A young woman did some porting of it to Python3 for the GRASS GIS project. I've been looking over the accessible versions of her patches.

-- Alan

On Fri, Feb 8, 2019, at 11:53 PM, borgified wrote:

I've forked ctypesgen to here https://github.com/assimilation/ctypesgen, since upstream seems to be abandoned. I tried adding the patches as prescribed by davidjamesca/ctypesgen#61 https://github.com/davidjamesca/ctypesgen/issues/61 and davidjamesca/ctypesgen#62 https://github.com/davidjamesca/ctypesgen/issues/62 and I'm still hitting the same errors indicated by the issues. @Alan-R https://github.com/Alan-R can you give it a shot at fixing ctypesgen? (make changes directly to assimilation/ctypesgen)

I've also tried other forks like olsonse/ctypesgen but they don't help either.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/assimilation/assimilation-official/issues/65, or mute the thread https://github.com/notifications/unsubscribe-auth/ABM0oxyIs8x_vV4Cd-ienL-iMHFPvxu5ks5vLnBNgaJpZM4ayaik.

-- Alan Robertson alanr@unix.sh

Alan-R commented 5 years ago

I had a couple of fixes I'd been talking to Dejan about. I need to make sure I apply those.

But cytpesgen needs to be fixed AND brought into Python3 compliance.

borgified commented 5 years ago

this fork in particular advertises itself being ready for python3: https://github.com/olsonse/ctypesgen at least that's what their 0.1.1 release says (https://github.com/olsonse/ctypesgen/releases)

i have already tried this repo previously and it didnt work for us but ill give it another try since this is probably the best shot we have to get ctypesgen python3 ready without having to do the work ourselves.

Alan-R commented 5 years ago

This is now resolved.