search

assimp / assimp

The official Open-Asset-Importer-Library Repository. Loads 40+ 3D-file-formats into one unified and clean data structure.
https://www.assimp.org
Other
10.81k stars 2.9k forks source link

Split aiProcess_FindInvalidData into two flags for meshes and animations #2583

Open maxvollmer opened 5 years ago

maxvollmer commented 5 years ago

This is a feature request.

Currently aiProcess_FindInvalidData removes invalid normals, invalid UV coords and meshes that are infinitely small. It also removes keyframes from animation tracks, if they are equal.

I request splitting this behavior into two: aiProcess_FindInvalidMeshData and aiProcess_RemoveDuplicateAnimationKeyFrames

After adding the new flags and updating Assimp to use them in post-processing, simply replace the previous aiProcess_FindInvalidData with a #define that ORs the new flags together.

RichardTea commented 5 years ago

This relates to #2606 The post-process API needs altering before any more flags can be added, as we've already run out of space in a 32bit signed int (as defined in the C11 standard)

maxvollmer commented 5 years ago

Thanks for the update!