search

assisi / assisipy

Python API for the ASSISI|bf project.
Other
0 stars 3 forks source link

links in nbg file need to have unique labels --> deploy.py should notify user if duplicates are present #68

Open rmm-fcul opened 8 years ago

rmm-fcul commented 8 years ago

If a link label is not unique, some links will be masked. This fails silently (and is a real pain to track down!)

deploy.py should emit a warning (perhaps raise fatal error) if duplicate link labels are found, since the generated .rtc file will not fully represent the graph.

dmiklic commented 8 years ago

You mean, labels should be unique for each node? To me this actually makes sense, because they have sort of a topological meaning in the context of CASU neighborhood, i.e., they are like "information road" between CASUs, and therefore do warrant unique names.

rmm-fcul commented 8 years ago

Yes, I meant "labels should be unique for each node" So a->b [label='inhibit']; c->d [label='inhibit'] is OK, but So a->b [label='inhibit']; a->d [label='inhibit'] is not.

I don't disagree with the policy. I think the deploy tool should warn or fail if the requested graph has duplicates. I updated the issue title to make this more explicit

dmiklic commented 8 years ago

Ok, got it. This makes perfect sense to me an it shouldn't be too hard to implement.