search

assisi / assisipy

Python API for the ASSISI|bf project.
Other
0 stars 3 forks source link

deploy tools fail if project file has more than one '.' in name #78

Open rmm-fcul opened 8 years ago

rmm-fcul commented 8 years ago

proj.thing.assisi causes a fabfile import failure during assisirun. However it is possible the original error is in the generated code by deploy.py.

rmm-fcul commented 6 years ago

testing with proj.assisi and proj.thing.assisi, the code generated is identical. the way that fab handles the pythonpath to run code makes an assumption that the directory has a single . (or whatever pathext is in currentlocale).

this is low priority, and we aren't going to change fab. Moreover, it might violate a python assumption about package naming and directory assumptions. So the two possibilities that I see are: a) substitute the project name (e.g. '.' --> '_') b) detect issue and warn or error (i.e. fail to generate the deployment dir).

I think doing (a) silently is asking for trouble. I prefer (b).