search

assistify / Rocket.Chat

Supercharged by AI: Learn the most of your communication
https://www.assistify.de
Other
14 stars 3 forks source link

[NEW] config experts can manage apps #652

Closed jschirrmacher closed 4 years ago

jschirrmacher commented 4 years ago

I added the permission for config-experts to manage apps.

jschirrmacher commented 4 years ago

When someone with manage-apps permission calls the marketplace, the following message appear:

Bildschirmfoto 2019-11-19 um 14 43 02

If they try to install an app, the same message is shown. It is still possible to enable / disable already installed apps. I tried that in our open workspace.

Though I don't know, which permission is necessary to use the marketplace, I don't see a problem here regarding giving manage-apps to config-manager role.

jschirrmacher commented 4 years ago

Current status: We checked that giving the permission manage-apps to config-experts doesn't allow them to connect the Marketplace with the Cloud, nor to install new apps, but only to enable/disable/configure apps which are already installed.

@mrsimpson will talk to RC people though, if this is the desired behavior or a bug.

ruKurz commented 4 years ago

@mrsimpson will talk to RC people though, if this is the desired behavior or a bug.

From the permission perspective, I would say it's correct. But from the UI perspective, I would say it's a usability bug. Since only experts are affected (which are hopefully fault tolerant), this is not that critical. We should report it to Rocket.Chat anyways.

jschirrmacher commented 4 years ago

So you think, we should merge this PR? @ruKurz