search

assistify / diary

Apache License 2.0
0 stars 1 forks source link

Extracted parser from component into separate module. #48

Closed jschirrmacher closed 5 years ago

jschirrmacher commented 5 years ago

Extracted parser from component into separate module. Still missing: test for parser module.

mrsimpson commented 5 years ago

What happens if the parser cannot parse Text properly? This is not really a question raised by the refactoring, but the interface should feature something like an error channel

Sent with GitHawk

jschirrmacher commented 5 years ago

Good question. What kind of texts do you think could not be parsed properly? I could imagine, if the user would not use the template, nothing would be recognized, so the resulting structure would be empty. So, it might be a good test case to give some text without any matches for the key sentences and then require an error listener (which is not yet implemented) to receive a proper error message. What do you think?