assistify / rcapps-gitlab

RocketChat App to connect to GitLab and GitLab-CI
Apache License 2.0
16 stars 5 forks source link

Naming conventions for configuration settings #1

Closed jschirrmacher closed 4 years ago

jschirrmacher commented 5 years ago

Currently, our App has two settings which are names very different: url and gitlab-username-alias. I think, we should standardize that!

Since each app has a separate name space for settings and even i18n texts, it is - so I think - not necessary to use the app name as a prefix as in gitlab-username-alias. On the other hand, I find url way too generic.

I propose, that we use names, that are both, descriptive and short like gitlab-url and username-alias