search

assistunion / xml-stream

XML stream parser based on Expat. Made for Node.
MIT License
318 stars 109 forks source link

Could you replace iconv with iconv-light? #77

Open zeg-io opened 5 years ago

zeg-io commented 5 years ago

My understanding is light is a completely native solution. I'm currently getting build errors on iconv

bushev commented 5 years ago

I have the same issue:

../../nan/nan_maybe_43_inl.h:112:15: error: no member named 'ForceSet' in 'v8::Object'
zeg-io commented 5 years ago

I make no guarantees and I'm not maintaining it, but this one I forked and fixed is working for me: https://github.com/zeg-io/xml-stream

sandinmyjoints commented 5 years ago

The build errors come from a dep of xml-stream, nan. Older versions of it won't build on Node 10. If you install a newish version of nan (2.11 or above, I believe), then it will build (and xml-stream will install).

zeg-io commented 5 years ago

Good to know, but iconv-light doesn't require a build at all and functions just fine, which is why I'd prefer it.

sandinmyjoints commented 5 years ago

No disagreement here, just offering a way forward for folks stuck with xml-stream as it is!