assume-framework / assume

ASSUME - Agent-based Simulation for Studying and Understanding Market Evolution
https://assume.readthedocs.io
23 stars 9 forks source link

Adressing some major issues with learning #212

Closed nick-harder closed 1 year ago

nick-harder commented 1 year ago

-fixed evaluation average reward calculation -fixed saving learned strategies -fixes profit and regret calculations -fixed missing unit_id in rejected orders -fixed issue when mcp is tensor -fixed some dashboards -fixed use of variable cost while inputs use fixed cost -added check if learning is on but no RL strategies are given -query for evarge reward in eval raises an error if not available

codecov[bot] commented 1 year ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (9dcd4d5) 82.02% compared to head (a0d1a09) 81.94%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #212 +/- ## ========================================== - Coverage 82.02% 81.94% -0.08% ========================================== Files 39 39 Lines 4056 4055 -1 ========================================== - Hits 3327 3323 -4 - Misses 729 732 +3 ``` | [Flag](https://app.codecov.io/gh/assume-framework/assume/pull/212/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=assume-framework) | Coverage Δ | | |---|---|---| | [pytest](https://app.codecov.io/gh/assume-framework/assume/pull/212/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=assume-framework) | `81.94% <97.87%> (-0.08%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=assume-framework#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/assume-framework/assume/pull/212?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=assume-framework) | Coverage Δ | | |---|---|---| | [assume/common/base.py](https://app.codecov.io/gh/assume-framework/assume/pull/212?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=assume-framework#diff-YXNzdW1lL2NvbW1vbi9iYXNlLnB5) | `78.22% <100.00%> (ø)` | | | [assume/common/forecasts.py](https://app.codecov.io/gh/assume-framework/assume/pull/212?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=assume-framework#diff-YXNzdW1lL2NvbW1vbi9mb3JlY2FzdHMucHk=) | `85.36% <100.00%> (ø)` | | | [assume/common/outputs.py](https://app.codecov.io/gh/assume-framework/assume/pull/212?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=assume-framework#diff-YXNzdW1lL2NvbW1vbi9vdXRwdXRzLnB5) | `80.61% <100.00%> (-1.12%)` | :arrow_down: | | [assume/common/units\_operator.py](https://app.codecov.io/gh/assume-framework/assume/pull/212?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=assume-framework#diff-YXNzdW1lL2NvbW1vbi91bml0c19vcGVyYXRvci5weQ==) | `91.00% <100.00%> (+0.09%)` | :arrow_up: | | [assume/markets/base\_market.py](https://app.codecov.io/gh/assume-framework/assume/pull/212?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=assume-framework#diff-YXNzdW1lL21hcmtldHMvYmFzZV9tYXJrZXQucHk=) | `89.44% <100.00%> (ø)` | | | [assume/markets/clearing\_algorithms/simple.py](https://app.codecov.io/gh/assume-framework/assume/pull/212?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=assume-framework#diff-YXNzdW1lL21hcmtldHMvY2xlYXJpbmdfYWxnb3JpdGhtcy9zaW1wbGUucHk=) | `95.65% <100.00%> (-0.07%)` | :arrow_down: | | [assume/strategies/learning\_strategies.py](https://app.codecov.io/gh/assume-framework/assume/pull/212?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=assume-framework#diff-YXNzdW1lL3N0cmF0ZWdpZXMvbGVhcm5pbmdfc3RyYXRlZ2llcy5weQ==) | `95.86% <100.00%> (+0.82%)` | :arrow_up: | | [assume/units/powerplant.py](https://app.codecov.io/gh/assume-framework/assume/pull/212?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=assume-framework#diff-YXNzdW1lL3VuaXRzL3Bvd2VycGxhbnQucHk=) | `90.47% <ø> (-1.39%)` | :arrow_down: | | [assume/common/scenario\_loader.py](https://app.codecov.io/gh/assume-framework/assume/pull/212?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=assume-framework#diff-YXNzdW1lL2NvbW1vbi9zY2VuYXJpb19sb2FkZXIucHk=) | `88.77% <88.88%> (-0.40%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.