assume-framework / assume

ASSUME - Agent-based Simulation for Studying and Understanding Market Evolution
https://assume.readthedocs.io
23 stars 9 forks source link

Mqtt fixes #222

Closed maurerle closed 1 year ago

maurerle commented 1 year ago

This includes fixes to running the MQTT container with docker for a distributed simulation.

For distributed simulations, one can start python examples/distributed_world_manager.py in one terminal and run python examples/distributed_world_agent.py in another one.

A registry of which agents are available (and must be online before simulation can start) and a central yaml config are still needed. So this is an early fix set, which should not change anything to existing behavior

codecov[bot] commented 1 year ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (606c335) 78.03% compared to head (7482680) 78.10%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #222 +/- ## ========================================== + Coverage 78.03% 78.10% +0.07% ========================================== Files 40 40 Lines 4198 4198 ========================================== + Hits 3276 3279 +3 + Misses 922 919 -3 ``` | [Flag](https://app.codecov.io/gh/assume-framework/assume/pull/222/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=assume-framework) | Coverage Δ | | |---|---|---| | [pytest](https://app.codecov.io/gh/assume-framework/assume/pull/222/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=assume-framework) | `78.10% <66.66%> (+0.07%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=assume-framework#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/assume-framework/assume/pull/222?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=assume-framework) | Coverage Δ | | |---|---|---| | [assume/common/outputs.py](https://app.codecov.io/gh/assume-framework/assume/pull/222?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=assume-framework#diff-YXNzdW1lL2NvbW1vbi9vdXRwdXRzLnB5) | `49.49% <100.00%> (+<0.01%)` | :arrow_up: | | [assume/markets/base\_market.py](https://app.codecov.io/gh/assume-framework/assume/pull/222?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=assume-framework#diff-YXNzdW1lL21hcmtldHMvYmFzZV9tYXJrZXQucHk=) | `87.63% <ø> (ø)` | | | [assume/world.py](https://app.codecov.io/gh/assume-framework/assume/pull/222?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=assume-framework#diff-YXNzdW1lL3dvcmxkLnB5) | `82.35% <57.14%> (+1.77%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kim-mskw commented 1 year ago

I hardly get what is happening here. Nice though if it works. I am looking forward to next development meeting :)

maurerle commented 1 year ago

Weird that get_sum_reward did not have a length and I needed to handle that case? This does not occur on my device though.