Closed maurerle closed 6 months ago
Attention: Patch coverage is 30.18868%
with 148 lines
in your changes are missing coverage. Please review.
Project coverage is 78.53%. Comparing base (
dbd53ad
) to head (2747bd7
).
Files | Patch % | Lines |
---|---|---|
assume/markets/clearing_algorithms/contracts.py | 31.31% | 125 Missing :warning: |
assume/strategies/extended.py | 20.68% | 23 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@maurerle why do you believe the feed-in premium should be handled by an extra demand agent, ant not an additional market party? Also, it would be better to add functionality when it is 100% operational and tested. So please same here, check functionality, and add tests for the new market clearing algorithms. Thanks :-)
@maurerle is this now ready?
I'd still like to add some tests - but I don't think that I find time this week. So we can merge this :)
@maurerle there is also no description of the new methods, no docstrings, and any mention of the new clearings in the documentation. It would be helpful to have them. Let's merge when tests and documentation are there, it can wait :-)
This PR implements a feed in policy, which calculates the value a special demand agent pays on top of the market prices as a feed-in-tariff. The contract is accepted on a monthly base for example, and evaluated on a weekly base. For this, the generation and market_price of the last week is requested using the data_request mechanism developed in #247 - then the resulting orderbook is created and sent to the contract participants using the already existing
clearing
process.This works in general, though the results are not correct yet. I think the volume and price is applied for the whole series and the dashboard needs some polishment too.