codecov[bot]
commented
11 months ago Codecov Report
Attention: 2 lines in your changes are missing coverage. Please review.
Comparison is base (
c32a623) 78.21% compared to head (cc74f6d) 78.33%.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #250 +/- ## ========================================== + Coverage 78.21% 78.33% +0.11% ========================================== Files 39 39 Lines 4214 4218 +4 ========================================== + Hits 3296 3304 +8 + Misses 918 914 -4 ``` | [Flag](https://app.codecov.io/gh/assume-framework/assume/pull/250/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=assume-framework) | Coverage Δ | | |---|---|---| | [pytest](https://app.codecov.io/gh/assume-framework/assume/pull/250/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=assume-framework) | `78.33% <90.47%> (+0.11%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=assume-framework#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/assume-framework/assume/pull/250?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=assume-framework) | Coverage Δ | | |---|---|---| | [assume/common/units\_operator.py](https://app.codecov.io/gh/assume-framework/assume/pull/250?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=assume-framework#diff-YXNzdW1lL2NvbW1vbi91bml0c19vcGVyYXRvci5weQ==) | `90.95% <100.00%> (+0.40%)` | :arrow_up: | | [assume/markets/base\_market.py](https://app.codecov.io/gh/assume-framework/assume/pull/250?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=assume-framework#diff-YXNzdW1lL21hcmtldHMvYmFzZV9tYXJrZXQucHk=) | `87.56% <100.00%> (+0.06%)` | :arrow_up: | | [assume/common/base.py](https://app.codecov.io/gh/assume-framework/assume/pull/250?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=assume-framework#diff-YXNzdW1lL2NvbW1vbi9iYXNlLnB5) | `80.26% <85.71%> (+1.33%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/assume-framework/assume/pull/250/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=assume-framework):umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
We still had an issue in the marginal_cost calculation which I fixed in a wrong way in #245 This is now tested and fixed. While testing, I found that the product_type was not used in the get_output_before function too.