assume-framework / assume

ASSUME - Agent-based Simulation for Studying and Understanding Market Evolution
https://assume.readthedocs.io
22 stars 5 forks source link

changed buffer add function call #255

Closed kim-mskw closed 9 months ago

kim-mskw commented 9 months ago

changed buffer add function call to not only add the first value of the observations 50 times.

I am wondering how it learned anything with these observations in the buffer...

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (3bddb13) 78.44% compared to head (e18d165) 78.44%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #255 +/- ## ======================================= Coverage 78.44% 78.44% ======================================= Files 39 39 Lines 4259 4259 ======================================= Hits 3341 3341 Misses 918 918 ``` | [Flag](https://app.codecov.io/gh/assume-framework/assume/pull/255/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=assume-framework) | Coverage Δ | | |---|---|---| | [pytest](https://app.codecov.io/gh/assume-framework/assume/pull/255/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=assume-framework) | `78.44% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=assume-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nick-harder commented 9 months ago

oh wow, that is weird error. I believe at some point observation contained past and future observations, so this was required. But at some point we probably shifted to use only one observation since next one could be sampled easily, but this part stayed