search

assume-framework / assume

ASSUME - Agent-based Simulation for Studying and Understanding Market Evolution
https://assume.readthedocs.io
22 stars 5 forks source link

Add collab tonotebooks #258

Closed nick-harder closed 9 months ago

nick-harder commented 9 months ago

-added rl as notebook to the repository -adjusted config to show collab at the top

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (afae9d8) 78.44% compared to head (b717ee6) 78.44%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #258 +/- ## ======================================= Coverage 78.44% 78.44% ======================================= Files 39 39 Lines 4259 4259 ======================================= Hits 3341 3341 Misses 918 918 ``` | [Flag](https://app.codecov.io/gh/assume-framework/assume/pull/258/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=assume-framework) | Coverage Δ | | |---|---|---| | [pytest](https://app.codecov.io/gh/assume-framework/assume/pull/258/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=assume-framework) | `78.44% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=assume-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kim-mskw commented 9 months ago

Love how easy and simple it look :) pretty cool!

I was wondering if we should give an outlook and link the more complex implementations there as well? For example: Here we defined the market, in the advanced example this is done with YAML files.

Or do you think that would be too confusing?

nick-harder commented 9 months ago

@kim-mskw yeah, these more compelx notebook will follow later. I wanted to construct dictsa and save them as csv files to demonstrate how to create a scenario and run it. For now I would like to find a good format for us to follow

kim-mskw commented 9 months ago

Yeah I know that it will follow later :) I was just wondering if we should mention or link the more complex option already somehow so that it is easier to draw the conclusion. Could be part of the structure then I guess.

nick-harder commented 9 months ago

@kim-mskw do you mean to add it directly in the notebook or what exactly? I don't understand. COuld you please make a suggestion directly in code? :-)

kim-mskw commented 9 months ago

Discussed in person