Closed adamsjohanna closed 7 months ago
Attention: 118 lines
in your changes are missing coverage. Please review.
Comparison is base (
5fa7460
) 81.78% compared to head (605a508
) 82.59%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I'm working on the review rigth now. Is there an example with which I can test the advanced learning strategies? So far the analysis_02 example does not have learning activated, does it?
Ok, I added the advanced orders learning to example_02_rl
Ok, I added the advanced orders learning to example_02_rl
example_02_rl is giving me a bunch of warning messages. Did you get the same?
"WARNING:pyomo.core:Element demand_EOM_18 already exists in Set Bids; no action taken WARNING:pyomo.core:Element Unit 1_18 already exists in Set Bids; no action taken WARNING:pyomo.core:Element Unit 2_18 already exists in Set Bids; no action taken WARNING:pyomo.core:Element Unit 3_18 already exists in Set Bids; no action taken WARNING:pyomo.core:Element Unit 4_18 already exists in Set Bids; no action taken WARNING:pyomo.core:Element demand_EOM_19 already exists in Set Bids; no action taken WARNING:pyomo.core:Element Unit 1_19 already exists in Set Bids; no action taken {...}"
I just pulled your changes and it still runs through. The only warning I get is "WARNING:mango.util.distributed_clock:clock: no new events, time stands still", which depends on the end_date of the simulation. The warning you have implies, that the cleared orders are not deleted from the orderbook before the next market opening. I will check this again...
Sorry - I took example_02c as it was the next one. We can rename the one on main so that this does not conflict anymore :)
Oh well, in pandas 2.2 they changed the freq aliases:
Deprecated since version 2.2.0: Aliases H, BH, CBH, T, S, L, U, and N are deprecated in favour of the aliases h, bh, cbh, min, s, ms, us, and ns. https://pandas.pydata.org/pandas-docs/stable/user_guide/timeseries.html#offset-aliases
(just as a note why this change seems to be required here)
@adamsjohanna also please make sure that the new learning startegies align with the changes Kim did last weeks for the learning part, and everyhting works. Also, since this is a pretty large commit, change the version in pyproject.toml to 0.3 since many new featured were added since November. We will create a new release after this commit
@nick-harder I don't think that changing the version should be added to this PR additionally. It is worth its own PR
@nick-harder I don't think that changing the version should be added to this PR additionally. It is worth its own PR
@maurerle yes true! I will create one after this is merged
I didn't check the dashboard, since I hope everything was checked and workes properly. Make check again the documentation style, add documentation for the several new strategies, and clean up the input files. Also, for the future please split such large commits into sevral work packages with smaller commit sizes, for example only clearing or only strategies, or fixes
All done, except for the documentation, see #278
Add functionalities from my thesis:
Allows to use block orders and linked orders as rule-based and RL-based strategies for EOM markets.