search

assume-framework / assume

ASSUME - Agent-based Simulation for Studying and Understanding Market Evolution
https://assume.readthedocs.io
22 stars 5 forks source link

Addes input files relevant for the unit example #271

Closed Manish-Khanra closed 7 months ago

Manish-Khanra commented 7 months ago

@nick-harder I have just committed the inpul files for the unit example. Could you please merge the pull request?

nick-harder commented 7 months ago

@Manish-Khanra please run tests before submitting PR. This one has failed due to the REUSE. Please add required headers and files

nick-harder commented 7 months ago

@Manish-Khanra also I am not sure why this needs to be a seperate commit. You could just add the files in the initial commit of the unit example. Or is this something specific?

Manish-Khanra commented 7 months ago

@nick-harder What do you mean by 'This one has failed due to the REUSE'? I needed a separate commit since I have to first include the input files in the main branch in order to successfully run the unit example script. It needs the required input from the main.

nick-harder commented 7 months ago

I mean, once it is commited, it would run.

I mean reuse is the specification, you can check out other input files for that. You can also install their package, it would do things automatically. I believe, Florian provided an instruction in the main github page for thay

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (6257e2b) 81.90% compared to head (9a1015b) 81.90%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #271 +/- ## ======================================= Coverage 81.90% 81.90% ======================================= Files 38 38 Lines 4161 4161 ======================================= Hits 3408 3408 Misses 753 753 ``` | [Flag](https://app.codecov.io/gh/assume-framework/assume/pull/271/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=assume-framework) | Coverage Δ | | |---|---|---| | [pytest](https://app.codecov.io/gh/assume-framework/assume/pull/271/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=assume-framework) | `81.90% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=assume-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.