search

assume-framework / assume

ASSUME - Agent-based Simulation for Studying and Understanding Market Evolution
https://assume.readthedocs.io
20 stars 5 forks source link

This commit prepares assume to integrate proper nodal pricing #304

Closed nick-harder closed 4 months ago

nick-harder commented 5 months ago

-delete old examplery nodal pricing -it will be replaced with pypsa model similar to redispatch -provide better description and structure for markets API documentation

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 8.03571% with 103 lines in your changes are missing coverage. Please review.

Project coverage is 77.42%. Comparing base (5e8cbf4) to head (f4e4d0c).

Files Patch % Lines
...ssume/markets/clearing_algorithms/nodal_pricing.py 4.22% 68 Missing :warning:
assume/common/grid_utils.py 0.00% 22 Missing :warning:
assume/markets/clearing_algorithms/redispatch.py 0.00% 7 Missing :warning:
assume/strategies/naive_strategies.py 44.44% 5 Missing :warning:
assume/markets/clearing_algorithms/__init__.py 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #304 +/- ## ========================================== - Coverage 77.45% 77.42% -0.04% ========================================== Files 43 43 Lines 5016 4996 -20 ========================================== - Hits 3885 3868 -17 + Misses 1131 1128 -3 ``` | [Flag](https://app.codecov.io/gh/assume-framework/assume/pull/304/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=assume-framework) | Coverage Δ | | |---|---|---| | [pytest](https://app.codecov.io/gh/assume-framework/assume/pull/304/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=assume-framework) | `77.42% <8.03%> (-0.04%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=assume-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nick-harder commented 5 months ago

@maurerle could you please take a look at this PR?

maurerle commented 5 months ago

I don't really see the reason in removing things without replacing them with better things, while we have a differen WIP PR open which improves this?

nick-harder commented 5 months ago

@maurerle I have now added the new nodal clearing similar to redispatch structure, but without all the extra funcitons. it uses the same input data and same example folder. Please take a look

nick-harder commented 4 months ago

@maurerle yeah, this one has to be significantly changed to be in line with the new version. I will work on it this week (hopefully) and let you know